Allow code review comments crossing commit with right line number #35077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
lunny
force-pushed
the
lunny/code_review_line_number
branch
2 times, most recently
from
fd82a60 to
791339a
Compare
lunny
commented
Jul 16, 2025
| @@ -730,28 +730,23 @@ func prepareIssueViewCommentsAndSidebarParticipants(ctx *context.Context, issue | |||
| } | |||
| comment.Review.Reviewer = user_model.NewGhostUser() | |||
| } | |||
| if err = comment.Review.LoadCodeComments(ctx); err != nil { | |||
There was a problem hiding this comment.
duplicated with LoadAttributes
lunny
force-pushed
the
lunny/code_review_line_number
branch
from
4e509fc to
3f4596f
Compare
…nch has a force-push
lunny
force-pushed
the
lunny/code_review_line_number
branch
from
3f4596f to
aaed5c9
Compare
lunny
changed the title
This was referenced Aug 1, 2025
lunny
added a commit
that referenced
this pull request
Aug 3, 2025
The commit range in the UI follows a half-open, half-closed convention: (,]. When reviewing a range of commits, the beforeCommitID should be set to the commit immediately preceding the first selected commit. For single-commit reviews, we must identify and use the previous commit of that specific commit. The endpoint ViewPullFilesStartingFromCommit is currently unused and can be safely removed. Fix #35157 Replace #35184 Partially extract from #35077
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Aug 10, 2025
The commit range in the UI follows a half-open, half-closed convention: (,]. When reviewing a range of commits, the beforeCommitID should be set to the commit immediately preceding the first selected commit. For single-commit reviews, we must identify and use the previous commit of that specific commit. The endpoint ViewPullFilesStartingFromCommit is currently unused and can be safely removed. Fix go-gitea#35157 Replace go-gitea#35184 Partially extract from go-gitea#35077
6543
pushed a commit
that referenced
this pull request
Aug 11, 2025
The commit range in the UI follows a half-open, half-closed convention: (,]. When reviewing a range of commits, the beforeCommitID should be set to the commit immediately preceding the first selected commit. For single-commit reviews, we must identify and use the previous commit of that specific commit. The endpoint ViewPullFilesStartingFromCommit is currently unused and can be safely removed. Fix #35157 Replace #35184 Partially extract from #35077 Backport #35192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30844
Fix #21113
Related to #31551
BeforeCommitIDbut notAfterCommitID. A doctor command to fix it have been introduced.ReadPatchCommit.